refactor(concurrency): consistent node-level locks #13382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
core/db
cherry-pick kong-ee
samugi
force-pushed
the
refactor/concurrency-worker-mutex-2
branch
7 times, most recently
from
406ac65 to
49e7450
Compare
nowNick
approved these changes
Aug 13, 2024
|
Hi @gruceo could you help and review this PR? thanks |
bungle
approved these changes
Aug 13, 2024
team-eng-enablement
added
author/community
Several places in the gateway need a node-level lock, some of them used slightly different implementations. This refactor brings consistency in the ways we do node-level locking by using the same implementation (concurrency.with_worker_mutex) everywhere.
samugi
force-pushed
the
refactor/concurrency-worker-mutex-2
branch
from
49e7450 to
5e74999
Compare
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the (reverted): #13055 - includes a fixup commit to address some log noise issues created by the original PR.
Several places in the gateway need a node-level lock, some of them used slightly different implementations. This refactor brings consistency in the ways we do node-level locking by using the same implementation (concurrency.with_worker_mutex) everywhere.
Note: in order to maintain the logic of declarative.import unaltered, the concurrency.with_worker_mutex function has been slightly modified to return an additional value ttl in case of timeout error, so that retry_after could be implemented as before.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-2337